Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a default title/label/assignee for the cherry pick request templates #19732

Merged
merged 1 commit into from Dec 11, 2018

Conversation

mrjoro
Copy link
Member

@mrjoro mrjoro commented Dec 7, 2018

GitHub recently added support for default titles/labels/assignees for issues filed with a template.

I'm not certain this will work with our templates since we use the older manual template method, but I am copying the format that's generated for the new template style to see if it works. (I think we chose to use the manual style since it allows us to expose the template through a link but not the main issue filing UI, which is preferable to avoid confusing people filing issues.)

/cc @adelinamart @rsimha

@adelinamart
Copy link
Contributor

That's so great. Let's see if it works correctly and we can modify the rest as well.

@mrjoro mrjoro requested review from adelinamart and removed request for erwinmombay December 11, 2018 18:41
Copy link
Contributor

@adelinamart adelinamart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrjoro mrjoro merged commit 4b96b9f into master Dec 11, 2018
@mrjoro mrjoro deleted the mrjoro-cherrypick-template branch December 11, 2018 22:13
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants