Remove wait for ini-load when layout a4a #19738
Conversation
|
Talked offline. I'll add a check for meta element within the ad creative to run an experiment. |
| checkStillCurrent(); | ||
| this.maybeTriggerAnalyticsEvent_('friendlyIframeIniLoad'); | ||
| }); | ||
| const isIniLoadFixExpr = !!frameDoc.querySelector( |
There was a problem hiding this comment.
I tried to use iframeDoc.head.querySelector, but found that Doubleclick has similar check and it doesn't require the meta tag in header, so I didn't include the head here.
| .callsFake(() => {return new Promise(() => {});}); | ||
| let creativeString = buildCreativeString(); | ||
| // TODO: Remove after launch fie_ini_load_fix to 100% | ||
| creativeString = creativeString.replace('<body>', |
There was a problem hiding this comment.
Couldn't find better way to mock the creative since they need to be signed. This is a workaround that will be removed soon.
|
I was wrong about the placeholder behavior. The loader and placeholder will be removed at PTAL |
extensions/amp-a4a/0.1/amp-a4a.js
Outdated
|
|
||
| // There's no need to wait for all resources to load. | ||
| // StartRender is enough | ||
| return; |
| // TODO: Remove after launch fie_ini_load_fix to 100% | ||
| creativeString = creativeString.replace('<body>', | ||
| '<body>' + | ||
| '<meta name="amp-experiments-opt-in" content="fie_ini_load_fix">'); |
There was a problem hiding this comment.
If you want to verify query selector is contains instead of exact, you can place text around the 'fie_ini_load_fix' string
* remove wait for ini-load * expr * fix presubmit * address comment
* remove wait for ini-load * expr * fix presubmit * address comment
* remove wait for ini-load * expr * fix presubmit * address comment
This is to fix the issue that Ad start layout on idle early but layout never finish because it is waiting for FIE ini-load.
This PR removes the wait for FIE ini-load, and change it render-start. Ad LayoutCallback should be completed once FIE start to render.
The change could help with the case if there are multiple ads on the page. It will also lead to loading indicator behavior change. But I think it's should be safe.
Please let me know if there's any concern. And if we want to run an experiment with it.