✅ Skip mutliple flaky tests #19796
Merged
✅ Skip mutliple flaky tests #19796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2018
|
@danielrozenberg @rsimha Skipping tests that used to pass before environment change is a bit risky IMO. Could we instead of skipping, have SauceLabs keep running Chrome 70 in blocking mode and 71 in non-blocking mode and then resolve the issues? Also some of these failures may have to do with the new environment rather than Chrome 71 itself. See this investigation by @cvializ for example: #19788 (comment) |
|
The tests skipped here all have to do the the |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Skip a flaky test * Skip two more tests and fix misconfigured skip in previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.