Mobile bookend opaque background. #19806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Dec 12, 2018
| } | ||
|
|
||
| .i-amphtml-story-bookend-active amp-story-page[active] { | ||
| [desktop].i-amphtml-story-bookend-active amp-story-page[active] { | ||
| filter: blur(3px) !important; | ||
| transition: filter 0.3s cubic-bezier(0.0, 0.0, 0.2, 1) !important; |
There was a problem hiding this comment.
don't we also need to remove this?
There was a problem hiding this comment.
It's still used on desktop, specifically on the new fullbleed experience. If you want to see how it looks, there's this demo or this screenshot :))
There was a problem hiding this comment.
got it. thanks! it feels much snappier
Enriqe
approved these changes
Dec 12, 2018
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fullbleed desktop demo
Panels desktop demo
Mobile demo