Remove i-amphtml-element class on forced disconnect #19858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
approved these changes
Dec 13, 2018
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an FIE is being removed, it calls
Resource.p.disconnecton all contained child resources. This deletes theResourceassociation.But some elements (ownership elements), during disconnect, ferry signals down to children. This is usually done by querying the DOM for
.i-amphtml-element. Elements with this class are supposed to have aResourceinstance, and we usually attempt to get theResourcefrom the element.But we just deleted it. Hence, bugs.
Fixes #18207
Fixes #18483
Fixes #16032