Rewrite some amp-bind integration tests #19895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
force-pushed
the
reenable-bind-tests
branch
from
945a2f4
to
459e28f
Compare
dreamofabear
force-pushed
the
reenable-bind-tests
branch
from
47ca4ce
to
52d3ebf
Compare
|
/to @alabiaga |
alabiaga
suggested changes
Dec 19, 2018
examples/bind/list.amp.html
Outdated
| @@ -10,7 +10,7 @@ | |||
| <script async src="https://cdn.ampproject.org/v0.js"></script> | |||
| <script async custom-element="amp-bind" src="https://cdn.ampproject.org/v0/amp-bind-0.1.js"></script> | |||
| <script async custom-element="amp-list" src="https://cdn.ampproject.org/v0/amp-list-0.1.js"></script> | |||
| <script async custom-template="amp-mustache" src="https://cdn.ampproject.org/v0/amp-mustache-latest.js"></script> | |||
| <script async custom-template="amp-mustache" src="https://cdn.ampproject.org/v0/amp-mustache-0.1.js"></script> | |||
There was a problem hiding this comment.
why this change? Should we use v0.2 as it is the version that will replace v0.1?
| } | ||
| AMP.registerTemplate('amp-mustache', AmpMustache); | ||
| AMP.extension(TAG, '0.2', function(AMP) { | ||
| // First, unregister template with to avoid "Duplicate template type" |
There was a problem hiding this comment.
Remove "with" in comment.
// First, unregister template with to avoid "Duplicate template type.
Also there is a test failure now that seems to indicate that moving this logic is causing this issue to happen again.
alabiaga
approved these changes
Dec 20, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Rewrite a few bind integration tests. * Rewrite carousel tests too. * Rewrite list and selector tests. * Skip Edge due to 'Permission denied' errors. * Support extension versions in describes.integration. * Replace weirdly written test-selector-list.js with a unit test. * Aaron's comments. * Remove .only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19789.
describes.integrationinstead of iframe fixtures.describes.integration.