Revert part of #19947 and #19680 which caused race condition for amp-analytics layout #19963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Yeah! |
lannka
changed the title
|
Rebranded the PR to fix a real issue. PTAL |
zhouyx
approved these changes
Dec 21, 2018
3 tasks
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…e condition for amp-analytics layout (ampproject#19963) * put amp-analytics > 3 viewports away in integration test * save a line * increase timeout, try to fix test * Revert part of ampproject#19947 and ampproject#19680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of #19947 and #19680 which caused race condition for amp-analytics layout.
see details about the race condition: #20049
added integration test to catch that.