Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code comment #19971

Merged
merged 1 commit into from Dec 20, 2018
Merged

Update code comment #19971

merged 1 commit into from Dec 20, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Dec 19, 2018

Follow up to #19958

Let me know if this is less confusing.

@zhouyx
Copy link
Contributor Author

zhouyx commented Dec 20, 2018

@jridgewell Super quick PR that update comment. PTAL

jridgewell
jridgewell approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My future self thanks you!

@zhouyx
Copy link
Contributor Author

zhouyx commented Dec 20, 2018

😄

@zhouyx zhouyx merged commit e7a503c into ampproject:master Dec 20, 2018
@zhouyx zhouyx deleted the update-comment branch December 20, 2018 23:16
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@zhouyx
update comment (ampproject#19971)
9fc00e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhouyx @jridgewell @googlebot