Fix Ampcontext variables in singlepass #19987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this could be caught by a skipped test #16825 |
|
pls hold this PR for the test unmute: #16828 |
|
FYI, the blocking PR is merged. |
|
Passing the JsonObject fix the issue. PTAL. @erwinmombay please let me know if it is safe to remove the externs we have. Thanks. |
zhouyx
changed the title
lannka
approved these changes
Dec 21, 2018
erwinmombay
reviewed
Dec 21, 2018
build-system/amp.extern.js
Outdated
| @@ -144,6 +144,9 @@ process.env.SERVE_MODE; | |||
| window.IS_AMP_ALT; | |||
|
|
|||
| // Exposed to ads. | |||
| // TODO: @erwinmombay I do believe this is safe to remove because | |||
| // All are passed to ampcontext in JsonObject. While isMaster and master is | |||
| // calculated in ampcontext-integration within the iframe. | |||
There was a problem hiding this comment.
you'd have to change all the reads to use bracket notation if you want to remove this
There was a problem hiding this comment.
There was a problem hiding this comment.
Asked @erwinmombay offline. We want to leave the extern for future optimization that is not related to singlepass. I removed my comment. We will need to add missing variables to the externs, or use bracket notation.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* add to extern * fix * remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ad script within iframe can access the variables, I believe we should add the vars to externs.
Let me know if this is the correct fix.
One thing that confuses me is that does it mean we should add every var and method from ampcontext.js to the extern list.
to @erwinmombay @lannka
Closes #20002