Make dep-check an order of magnitude faster. #20050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime goes down from over 4 minutes to 20 seconds. Change: Instead of processing every entry point by itself, create a temporary file that imports all entry points and process that.
rsimha
approved these changes
Dec 21, 2018
erwinmombay
reviewed
Dec 21, 2018
| @@ -195,7 +203,9 @@ function getGraph(entryModule) { | |||
| .pipe(source(entryModule)) | |||
| // Unfortunately we need to write the files out. | |||
| .pipe(gulp.dest('./.amp-build')) | |||
| .on('end', resolve.bind(null, module)); | |||
| .on('end', () => { | |||
There was a problem hiding this comment.
Just personal preference in readability
erwinmombay
approved these changes
Dec 21, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Runtime goes down from over 4 minutes to 20 seconds. Change: Instead of processing every entry point by itself, create a temporary file that imports all entry points and process that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime goes down from over 4 minutes to 20 seconds.
Change: Instead of processing every entry point by itself, create a temporary file that imports all entry points and process that.