Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Print a warning on Travis if a PR's commit log is unexpectedly long #20061

Merged
merged 2 commits into from Dec 26, 2018
Merged

🏗 Print a warning on Travis if a PR's commit log is unexpectedly long #20061

merged 2 commits into from Dec 26, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Dec 21, 2018

This prints a non-blocking warning in cases like this: https://travis-ci.org/ampproject/amphtml/jobs/471176835#L621

@rsimha rsimha self-assigned this Dec 21, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Dec 21, 2018 •
edited

/to @erwinmombay @danielrozenberg @estherkim

@estherkim
Copy link
Collaborator

Can we use template literals instead of string concats here?

https://github.com/rsimha/amphtml/blob/28ebd90feb8c22f9f95385443a37a73f66962c05/build-system/git.js#L80-L88

@rsimha
Copy link
Contributor Author

rsimha commented Dec 26, 2018

@estherkim done. PTAL.

estherkim
estherkim approved these changes Dec 26, 2018
View reviewed changes
Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsimha rsimha merged commit 0463a1e into ampproject:master Dec 26, 2018
@rsimha rsimha deleted the 2018-12-21-CommitLogWarning branch December 26, 2018 19:01
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@rsimha
🏗 Print a warning on Travis if a PR's commit log is unexpectedly long (…
94635b2 
…ampproject#20061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherkim estherkim estherkim approved these changes

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

@danielrozenberg danielrozenberg Awaiting requested review from danielrozenberg

Assignees

@rsimha rsimha

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @estherkim @googlebot @ampprojectbot