Attempt to stabilize amp-list integration tests #20063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparhami
approved these changes
Dec 26, 2018
| @@ -30,15 +31,30 @@ describe('amp-list (integration)', function() { | |||
| '</amp-list>`; | |||
|
|
|||
| const basicTests = env => { | |||
|
|
|||
| let browser, win, doc; | |||
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* use waitForLayout before clicking things * Add build test * One let per line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitForElementLayoutcall before clicking buttons to changeamp-listlayout toCONTAINER.waitForElementLayoutinstead of waiting for children to equal 3.So most of these tests have been finishing on my laptop within 0.1 seconds for Chrome, Safari, and FF. I'm not sure I understand why the timeouts have to be so high...