Add mox.tv ad network integration for amp-ad #20076
Conversation
There was a problem hiding this comment.
Thanks for adding your vendor to AMP! 😄
Just a small question on the config, and also, one last request I would like to make:
Can you add your vendor to: extensions/amp-ad/amp-ad.md, it's sorted alphabetically so add yourself in the appropriate place.
Thank you very much again! 😄 👍
ads/_config.js
Outdated
| @@ -642,6 +642,8 @@ export const adConfig = { | |||
| renderStartImplemented: true, | |||
| }, | |||
|
|
|||
| 'mox': {}, | |||
There was a problem hiding this comment.
Hello! Just wanted to make sure, your servers don't support renderStart, or prefetch? From my understanding this improves performance on our end.
cc @zhouyx
There was a problem hiding this comment.
There was a problem hiding this comment.
Hello!
I've added some improvements to config but integration tests has failed.
I didn't understand an error explanation and don't know how to fix it
|
Hello! So the integration test was a flaky test on our end, so no worries! 😄 However, I went ahead and tested the ad manually, and got the following: Testing Testing render start in So first, I noticed the ad is only 1px tall, so we cannot see the ad, without manually making it larger in the example. Also, we noticed renderStart is never being called. I tried this in mobile device emulation, so I am not sure if it is something wrong with the server, or the AMP implementation. 🤔 Either way, let me know how we can resolve these issues, and I think it will be good to go! 👍 Thank you! |
|
Hi! |
|
@llays Hello! So I tried on multiple different device emulations in the dev tools, two real life devices (Pixel 2 Android, iPhone 6 SE), and through a Candian VPN I have set up. And the ad was still not getting filled on my end unfortunately 😢 Is everything working on your end when you serve |
|
@torch2424 Hello! I have great news, we've found a bug due to which you had no ad. And we've already fixed it! Could you please recheck again?
Yes, I check it before every push. Thank you! |
|
Thank you for fixing that! Also, thank you for checking the example before pushing, helps us a lot 😄 Going to merge this in, thank you very much for your contribution! 👍 |
|
Thank you very much for participating! 🙌👍 |
* Add mox.tv ad network integration for amp-ad * Added more efficient config * Added mox.tv to supported ad networks list * Remove useless preconnect
No description provided.