🐛Fix lightbox transition when things on the page have z-index #20078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
approved these changes
Dec 26, 2018
| @@ -277,7 +277,7 @@ amp-lightbox-gallery .amp-carousel-button { | |||
| .i-amphtml-lightbox-gallery-trans { | |||
| pointer-events: none !important; | |||
| position: fixed !important; | |||
| z-index: 1001 !important; | |||
| z-index: 2147483642 !important; | |||
There was a problem hiding this comment.
Should we add documentation or at least a comment to the effect to say that elements with equal or higher z-index will still suffer from this problem until we fix it? Maybe just a comment here saying that this is necessary for fixing this bug here will suffice for now.
| @@ -277,7 +277,7 @@ amp-lightbox-gallery .amp-carousel-button { | |||
| .i-amphtml-lightbox-gallery-trans { | |||
| pointer-events: none !important; | |||
| position: fixed !important; | |||
| z-index: 1001 !important; | |||
| z-index: 2147483642 !important; | |||
| top: 0 !important; | |||
There was a problem hiding this comment.
Since with the animation library, we no longer need this element to be sized to the viewport size anymore, let's see if we can move the top, bottom, left, right CSS for this and reduce some bloat?
There was a problem hiding this comment.
Reworked this a bit and removed the transition layer element completely.
sparhami
force-pushed
the
lightbox-stack
branch
from
2609976
to
d6589ef
Compare
sparhami
force-pushed
the
lightbox-stack
branch
from
d6589ef
to
3dce48b
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…ject#20078) * Fix amp-lightbox-gallery transition when things on the page have z-index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @aghassemi
Fixes #20066