New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Introduce varGroups
for configRewriter.
#20190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed offline, it will be good to have a integration test first , so that we're confident about any new changes.
Ok this should be ready for another round of review 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zikas FYI
@lannka this wound up being a decent size refactor (also added some more tests) PTAL. Now we have 2 options where either pub or vendor can enable this feature. Also made sure we delete the |
* add vargroups * move varGroups to its own method * write test * jsdoc * separate out fake config * add integration and error handling * presubmit checks * comments * fix types * allow vendors to enable
Vendor API
Publisher API
Payload
Also introduces mock vendor that can be used for examples and local testing.