Add amp-analytics vendor config for INFOnline #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
infonline
branch
from
e1640f7
to
a208943
Compare
| 'pageview': { | ||
| 'on': 'visible', | ||
| 'request': 'pageview', | ||
| 'iframePing': true |
There was a problem hiding this comment.
Change this to
'iframe' + /* TEMPORARY EXCEPTION */ + 'Ping'
to pass presubmit
sebastianbenz
force-pushed
the
infonline
branch
from
a208943
to
42ff54d
Compare
|
PTAL |
| 'vars': { | ||
| "sv": "ke", | ||
| "ap": "1", | ||
| "url": "https://3p.ampproject.net/custom/amp-analytics-infonline.html" |
There was a problem hiding this comment.
Please move this into the request.
|
LGTM with one comment |
| 'pageview': { | ||
| 'on': 'visible', | ||
| 'request': 'pageview', | ||
| 'iframe' + /* TEMPORARY EXCEPTION */ + 'Ping' |
There was a problem hiding this comment.
Delete this line and add this to the end of the file:
ANALYTICS_CONFIG['infonline']['triggers']['pageview'][ 'iframe' + /* TEMPORARY EXCEPTION */ + 'Ping'] = true;
sebastianbenz
force-pushed
the
infonline
branch
from
42ff54d
to
06cb3b5
Compare
| }; | ||
| ANALYTICS_CONFIG['infonline']['triggers']['pageview'][ 'iframe' + /* TEMPORARY EXCEPTION */ + 'Ping'] = true; |
There was a problem hiding this comment.
This will need a line break for lint.
There was a problem hiding this comment.
lint is happy now
sebastianbenz
force-pushed
the
infonline
branch
2 times, most recently
from
cea4e30
to
6abb6fe
Compare
|
Added canonicalHost and canonicalPath to request. PTAL. |
|
LGTM |
cramforce
added a commit
that referenced
this pull request
Feb 15, 2016
Add amp-analytics vendor config for INFOnline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.