More fixes for git baseline selection in pr-check #20216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
pushed a commit
to danielrozenberg/amphtml
that referenced
this pull request
Jan 9, 2019
danielrozenberg
force-pushed
the
travis-test-local-changes-baseline
branch
from
92d5afb
to
806578f
Compare
added 6 commits
January 9, 2019 18:00
danielrozenberg
force-pushed
the
travis-test-local-changes-baseline
branch
from
a0b6ab6
to
36055de
Compare
rsimha
reviewed
Jan 9, 2019
rsimha
approved these changes
Jan 9, 2019
|
For posterity, here are the tests for the logic:
In all cases, the values returned by the modified function was the one we wanted |
|
Nice work with all the checks in #20216 (comment). One last corner case to verify: Reopen #20231 after one or more new commits have been merged to |
|
Done. Updated #20216 (comment) |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* More fixes for git baseline selection in pr-check * Fix typo * Use `master`, not `origin/master`, when choosing merge-base * Also print TRAVIS_COMMIT * Use TRAVIS_PULL_REQUEST_SHA instead of TRAVIS_COMMIT * Do not print TRAVIS_COMMIT * Address Raghu's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
TRAVIS_COMMIT_RANGEis frozen at the point of the PR's creation, not when the PR check is actually running.