Exclude the attachment media from the page media playback. #20264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enriqe
reviewed
Jan 10, 2019
| ALL_AMP_MEDIA: 'amp-audio, amp-video, amp-img, amp-anim', | ||
| ALL_MEDIA: 'audio, video', | ||
| ALL_VIDEO: 'video', | ||
| ALL_AMP_MEDIA: 'amp-story-grid-layer amp-audio, ' + |
There was a problem hiding this comment.
What about background-audio specified in an amp-story, do we want to also include that?
There was a problem hiding this comment.
This one is handled at the amp-story.js level, eg: https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/1.0/amp-story.js#L2042
There was a problem hiding this comment.
Nvm, just realized we don't do that normally, even with the background-audio of an amp-story-page.
Enriqe
approved these changes
Jan 10, 2019
gmajoulet
force-pushed
the
attachment_component_exclude_media
branch
from
978a2e9
to
4514774
Compare
This was referenced Jan 23, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…t#20264) * Exclude the attachment media from the page media playback. * Fixing unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude the attachment media from the page media playback, to ensure that:
#20209