馃悰 amp-ad: fixed URL handling on uzou.js #20342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send
changed the title
|
@lannka Please check for travis. Maybe occurred timeout error... |
|
/cc @ampproject/wg-monetization |
zhouyx
reviewed
Jan 16, 2019
| @@ -33,6 +32,7 @@ export function uzou(global, data) { | |||
| }; | |||
|
|
|||
| const widgetParams = parseJson(data['widgetParams']); | |||
| const akamaiHost = widgetParams['akamaiHost'] || 'speee-ad.akamaized.net'; | |||
There was a problem hiding this comment.
We usually ask the contributor to wrap url params with #encodeURIComponent(), but since it is the host, I believe you won't want that. @send to confirm
There was a problem hiding this comment.
And simply to make sure the new change is documented your side.
There was a problem hiding this comment.
We only use akamaiHost param for debugging purpose. And this param is the host part of ad script url. So we don't need wrap this one.
However, uzoInjector.url is expected encoding based on RFC 3986. So we have fixed it.
zhouyx
approved these changes
Jan 17, 2019
|
LGTM. Merged. |
|
thanks ! |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* fixed urls * fixed URI encoding * using rfc3986 * fixed lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fixed URL handling on uzou.js for our ad network.
sourceUrlinstead ofcanonicalUrlakamaiHostto usedata-widget-paramsCould you review our commits?
Regards.