Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xpath support to e2e test controllers #20351

Merged
merged 1 commit into from Jan 15, 2019

Conversation

estherkim
Copy link
Collaborator

This adds the xpath support that @sparhami added to cvializ/ampft-example here cvializ/ampft-example@8daa4c9

Copy link
Contributor

@cvializ cvializ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I'll merge when the build is green.

@cvializ cvializ merged commit d5c40d8 into ampproject:master Jan 15, 2019
@estherkim estherkim deleted the xpath-support branch January 17, 2019 21:25
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants