Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[amp-story] Fix progress bar issue馃悰 #20354

Merged
merged 1 commit into from Jan 15, 2019
Merged

[amp-story] Fix progress bar issue馃悰 #20354

merged 1 commit into from Jan 15, 2019

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Jan 15, 2019

Fixes #20346

With the will-change property on transform, transition, the progress bar would sometimes not be filled correctly. This might have been caused by optimizations made by it.

This PR removes the will-change property from the progress bar.

@Enriqe Enriqe self-assigned this Jan 15, 2019
@Enriqe Enriqe requested a review from gmajoulet January 15, 2019 21:29
gmajoulet
gmajoulet approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@gmajoulet gmajoulet merged commit 8cff979 into ampproject:master Jan 15, 2019
@Enriqe Enriqe deleted the progress-bar-bug branch February 28, 2019 17:09
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@Enriqe
fix progress issue (ampproject#20354)
89a93fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees

@Enriqe Enriqe

Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Enriqe @gmajoulet @googlebot @ampprojectbot