Update gulp e2e #20386
Merged
Update gulp e2e #20386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jan 17, 2019
danielrozenberg
approved these changes
Jan 17, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Update gulp e2e * Update path * extensions e2e tests need to be in test-e2e dir * Turn e2e test paths into build-system/config const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
gulp e2eto look for tests inextensions/**/test-e2e. The idea is that for testing a single component, it should live in its own dir.This is in addition to tests that live in
test/e2e, which is where tests with multiple components should live.Example where e2e tests can live: