Move testing/e2e files to build-system/tasks/e2e #20410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jan 17, 2019
| "after": false, | ||
| "assert": false, | ||
| "describes": true, | ||
| "Key": false |
There was a problem hiding this comment.
Optional future cleanup: Maintain this list in one place.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Move testing/e2e files to build-system/tasks/e2e * Fix gulp ava errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the e2e testing support files from
testing/e2etobuild-system/tasks/e2eso that we can lazy load NPM packages like selenium-webdriver and chromedriver in the future (#20320)It will also help clean up the
testingfolder, which will only contain integration testing support. Plan is to move these files tobuild-system/tasksas well and delete thetestingfolder altogether.(In moving these files, I had to fix a lot of eslint errors).