Prevent extensions from depending on extensions #20412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
reviewed
Jan 17, 2019
|
Wait, we didn't have this? Could it be that it was deleted at some point? |
I don't think we ever had it. Each extension would have to whitelist itself: With this new code, that's allowed by default. Only the exceptional cases need to be added to the whitelist. |
jridgewell
force-pushed
the
cross-extension-deps
branch
from
8e4303e
to
ff9d310
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Prevent extensions from depending on extensions * Fix * Fix whitelist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe would have prevented #20392