Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inabox-viewport measure the top level window directly if same domain #20459

Merged
merged 27 commits into from
Feb 27, 2019
Merged

Make inabox-viewport measure the top level window directly if same domain #20459

merged 27 commits into from
Feb 27, 2019

Commits on Jan 22, 2019

  1. Make inabox-viewport measure the top level window directly if same do… 

    …main

Instead of sending a post message, if the inabox iframe can directly measure the host window then have it get its position directly from there.
    @zombifier
    zombifier committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    d6612a9 View commit details
    Browse the repository at this point in the history

  2. fix types

    @zombifier
    zombifier committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    f03abfb View commit details
    Browse the repository at this point in the history

  3. Fix presubmit

    @zombifier
    zombifier committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    ea78dc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Test disconnect function

    @zombifier
    zombifier committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    4fbd385 View commit details
    Browse the repository at this point in the history

  2. Fix lint in new test

    @zombifier
    zombifier committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    f4b0d21 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Merge branch 'upstream' into inabox_friendly

    @zombifier
    zombifier committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    4655d6a View commit details
    Browse the repository at this point in the history

  2. Try enabling friendly, no host script inabox test on Safari

    @zombifier
    zombifier committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5947bfb View commit details
    Browse the repository at this point in the history

  3. Trivial fix to rerun Travis

    @zombifier
    zombifier committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    37d2b15 View commit details
    Browse the repository at this point in the history

  4. Try the no host script test with the example AMP ad 

    Checking if the serve mode of the example AMP test is changed somehow
    @zombifier
    zombifier committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5b0627c View commit details
    Browse the repository at this point in the history

  5. don't whitelist the iframe

    @zombifier
    zombifier committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    2dc3ce5 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. More work

    @zombifier
    zombifier committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    a15e80f View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @zombifier
    zombifier committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    48771c6 View commit details
    Browse the repository at this point in the history

  3. Fix lint in test

    @zombifier
    zombifier committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    18fcc29 View commit details
    Browse the repository at this point in the history

  4. fix oops

    @zombifier
    zombifier committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    f226409 View commit details
    Browse the repository at this point in the history

  5. Throttle the listeners

    @zombifier
    zombifier committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    a862336 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Use the existing inabox host observer instead of rewriting a new one 

    This makes the code cleaner and changes in the future easier
    @zombifier
    zombifier committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    ad8ca83 View commit details
    Browse the repository at this point in the history

  2. fix type issue

    @zombifier
    zombifier committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1d59138 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. Revert the changes to test-amp-inabox.js 

    I believe that the while the integration tests do test the inabox host script, they're are not actually testing the local AMP inabox run time. This might have to be fixed in a separate PR.
    @zombifier
    zombifier committed Jan 31, 2019
    Configuration menu
    Copy the full SHA
    bdbab11 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Gate the behavior behind experiment, and move canInspectWindow to hel… 

    …per file
    @zombifier
    zombifier committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    d57a414 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Merge branch 'upstream' into inabox_friendly

    @zombifier
    zombifier committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    5710e6f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'upstream' into inabox_friendly

    @zombifier
    zombifier committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    46ef8d3 View commit details
    Browse the repository at this point in the history

  3. Integrate the changes in ampproject#20599, and make sure the position… 

    … observer is not null.
    @zombifier
    zombifier committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    e36c257 View commit details
    Browse the repository at this point in the history

  4. Inline the function

    @zombifier
    zombifier committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    1553d9c View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Fix type

    @zombifier
    zombifier committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    bf4dc5a View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Merge branch 'upstream' into inabox_friendly

    @zombifier
    zombifier committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    ee941d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. Disconnect observer properly, and add a TODO to investigate a quirk i… 

    …n the listener.

Specifically, why is Resources needed.
    @zombifier
    zombifier committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    7f15bbb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'upstream' into inabox_friendly

    @zombifier
    zombifier committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    7780a9d View commit details
    Browse the repository at this point in the history