🐛Avoid clipping bottom of carousel slides on desktop. #20513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsalgueiro
added a commit
to jsalgueiro/amphtml
that referenced
this pull request
Jan 25, 2019
* commit '90a770f9871be4f45e12c024066174173d468af7': (93 commits) ✨ Support new ad type for Zucks ad network (ampproject#20206) ✨ Improve kuadio ad network optional params data-ref (ampproject#19813) ✨Adding Click Target to Amp-ad-exit (ampproject#20373) Pause the story when the landscape overlay warning is displayed. (ampproject#20498) Clean up inabox-rov experiment. (ampproject#20111) 🐛 [auto-lightbox] Relax schema parsing (ampproject#20518) 🐛 Hide gallery button when displaying single item (ampproject#20516) 🐛 amp-recaptcha-input: Specified / Check bootstrap frame origin in the recaptcha service (ampproject#20358) Apply length check to consent string (ampproject#20493) Avoid clipping bottom of carousel slides on desktop. (ampproject#20513) Move preventDefault before amp-ad-exit filters (ampproject#20243) ✨Notify amp-lightbox-gallery of new lightbox elements (ampproject#20485) Add rbinfox (ampproject#20451) [amp-list] guarantee space for load-more button instead of overlaying on content (ampproject#20332) 💅 Docking and undocking transition polish (ampproject#20508) 🐛story: fix fie querySelector (ampproject#20506) 🚮 Remove amp-date-display experiment (ampproject#20505) 🏗 Fetch and print sauce labs status before connecting (ampproject#20504) Fixed OnNetwork amp ad example (ampproject#20507) Added TcsEmotion ad support to amp-ad (ampproject#20367) ...
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #18352, but does not work for Firefox (and presumably IE/Edge). This is a short term improvement until a better solution can be found.