Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Wait an extra minute for sauce connect #20560

Merged
merged 2 commits into from Feb 7, 2019
Merged

🏗 Wait an extra minute for sauce connect #20560

merged 2 commits into from Feb 7, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 28, 2019

We're seeing cases where sauce connect hasn't been able to set up a tunnel in the allocated 60 seconds.

See https://travis-ci.org/ampproject/amphtml/jobs/485526351#L784

@rsimha rsimha self-assigned this Jan 28, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Jan 29, 2019

Didn't work. There's an outage.

@rsimha rsimha closed this Jan 29, 2019
@rsimha rsimha deleted the 2019-01-28-SauceConnect branch January 29, 2019 00:22
@rsimha rsimha restored the 2019-01-28-SauceConnect branch February 7, 2019 00:48
@rsimha
Copy link
Contributor Author

rsimha commented Feb 7, 2019

@erwinmombay @torch2424 let's try this.

@rsimha rsimha reopened this Feb 7, 2019
@rsimha rsimha requested a review from torch2424 February 7, 2019 00:51
Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 May want to wait for @erwinmombay 's review as well though.

@rsimha
Copy link
Contributor Author

rsimha commented Feb 7, 2019

Logs reveal some failing checks for entries in the hosts file. Force merging to see if this is consistent.

@rsimha rsimha merged commit 5999f7c into ampproject:master Feb 7, 2019
@rsimha rsimha deleted the 2019-01-28-SauceConnect branch February 7, 2019 01:37
rsimha added a commit that referenced this pull request Feb 7, 2019
nbeloglazov pushed a commit to nbeloglazov/amphtml that referenced this pull request Feb 12, 2019
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants