馃殌 [devdash] Render file list statically as placeholder #20600
Conversation
alanorozco
force-pushed
the
devdash-list
branch
from
8ef5ebd
to
5e67f8c
Compare
| * limitations under the License. | ||
| */ | ||
|
|
||
| const thru = a => a; |
There was a problem hiding this comment.
Can we have a more descriptive name for this? 馃槃
There was a problem hiding this comment.
Something like returnArguments?
There was a problem hiding this comment.
It's pretty self-descriptive, no? It's only used in composition and it's not being exported.
| * @return {string} | ||
| * @template T | ||
| */ | ||
| const many = (fragments, opt_renderer) => |
There was a problem hiding this comment.
Can we have a more descriptive name for this? 馃槃
There was a problem hiding this comment.
Something like, joinHtmlFragments?
There was a problem hiding this comment.
Hmm, this is only used in the context of HTML fragments. If context is needed the export can be used by html = require('./html-helpers'), html.many(...). I would rather keep a succinct name.
There was a problem hiding this comment.
But yeah, might be too broad. Renamed to joinFragments.
| const {SettingsModal, SettingsOpenButton} = require('./settings'); | ||
|
|
||
| const fileListEndpointPrefix = '/dashboard/api/listing'; | ||
|
|
||
| const examplesPathRegex = /^\/examples\//; |
There was a problem hiding this comment.
Can we move these regex into its own file, or constants object? 馃
There was a problem hiding this comment.
It's a little cluttered at the moment but I plan to split this file semantically. That way constants will retain meaning without being exported or cluttering.
| const ampStateKey = (...keys) => keys.join('.'); | ||
|
|
||
| const selectModeStateId = 'documentMode'; | ||
| const selectModeStateKey = 'selectModePrefix'; |
There was a problem hiding this comment.
Same for these types of variables. Can they ben in a constants object? 馃槃
build-system/app-index/template.js
Outdated
| <script type="application/json"> | ||
| {"src": "/dashboard/api/listing?path=${basepath}"} | ||
| ${JSON.stringify(state)} |
| @@ -0,0 +1,106 @@ | |||
| /** | |||
| * Copyright 2018 The AMP HTML Authors. All Rights Reserved. | |||
) Prevents flash of unloaded content! Also: - automatically finds required AMP extensions in document string. - fixes a validation error for `amp-mustache`. Closes ampproject#19896.
) Prevents flash of unloaded content! Also: - automatically finds required AMP extensions in document string. - fixes a validation error for `amp-mustache`. Closes ampproject#19896.
Prevents flash of unloaded content!
Also:
amp-mustache.Closes #19896.