Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add visual diff tests for <amp-selector> #20628

Merged

Conversation

danielrozenberg
Copy link
Member

Static + 2 interactive tests

@danielrozenberg
Copy link
Member Author

/cc @ampproject/wg-ui from the workshop

Copy link
Contributor

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 🎉 🚢 :shipit: 🚀 ✅

@danielrozenberg danielrozenberg merged commit 66af51f into ampproject:master Jan 31, 2019
@danielrozenberg danielrozenberg deleted the visual-diff-workshop branch January 31, 2019 23:56
nbeloglazov pushed a commit to nbeloglazov/amphtml that referenced this pull request Feb 12, 2019
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants