Make sure that infinite scroll actually ends #20647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
force-pushed
the
bugfix/scroll-end
branch
from
ac6d876
to
3ae605e
Compare
cathyxz
force-pushed
the
bugfix/scroll-end
branch
from
3ae605e
to
8d83112
Compare
|
xD yes. |
nbeloglazov
pushed a commit
to nbeloglazov/amphtml
that referenced
this pull request
Feb 12, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should reload (fetch with the same url) infinite scroll if loading failed, but not otherwise (since that indicates that infinite scroll ended).