馃悰 Have purifier.js allow unknown protocols #20710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
changed the title
|
Nice work. Can you add a unit test to test-purifier.js please? |
dreamofabear
reviewed
Feb 6, 2019
| @@ -280,6 +280,8 @@ export function purifyConfig() { | |||
| FORCE_BODY: true, | |||
| // Avoid need for serializing to/from string by returning Node directly. | |||
| RETURN_DOM: true, | |||
| // BLACKLISTED_ATTR_VALUES are enough. Other unknown protocols are safe. | |||
There was a problem hiding this comment.
Let's also mention that this allows native app deeplinks specifically.
dreamofabear
approved these changes
Feb 8, 2019
nbeloglazov
pushed a commit
to nbeloglazov/amphtml
that referenced
this pull request
Feb 12, 2019
* Have purifier.js allow unknown protocols. * Add unit test for allowing arbitrary protocols. * Add required 'target' attribute to tags in arbitrary protocols test. * Lint fix for unknown protocols test.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Have purifier.js allow unknown protocols. * Add unit test for allowing arbitrary protocols. * Add required 'target' attribute to tags in arbitrary protocols test. * Lint fix for unknown protocols test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@choumx