♻️ Refactor dom.js to have similar functions be close to each other and have more accurate names. #20717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml into delima02-double-functions
|
This pull request introduces 2 alerts when merging 788d692 into 9f78741 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 2 alerts when merging 1230192 into 9f78741 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
dreamofabear
reviewed
Feb 8, 2019
src/service/navigation.js
Outdated
| @@ -310,7 +310,8 @@ export class Navigation { | |||
| if (e.defaultPrevented) { | |||
| return; | |||
| } | |||
| const target = closestByTag(dev().assertElement(e.target), 'A'); | |||
| const target = | |||
| closestAncestorElementByTag(dev().assertElement(e.target), 'A'); | |||
There was a problem hiding this comment.
Nit: This indentation is wrong.
const element = dev().assertElement(e.target);
const target = closestAncestorElementByTag(element, 'A');Check out the Google JS style guide (we don't follow this exactly): https://google.github.io/styleguide/jsguide.html
dreamofabear
approved these changes
Feb 8, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…nd have more accurate names. (ampproject#20717) * Move ancestorElementsByTag closer to similar functions. * Rename 'closest' functions in dom.js to more accurate nomenclature. * Have child-related functions be next to ancestor-related ones in dom.js. * Make all usages of the renamed functions use the correct names. * Make all usages of the renamed functions use the correct names. * Lint all changes in this branch. * Update usages of closestAncestorElementBySelector missed in past commits * Indentation formatting at navigation.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ancestorElementsandancestorElementsByTagclose to other similar functions indom.js.closestByTagandclosestBySelectortoclosestAncestorElementByTagandclosestAncestorElementBySelector, respectively.childrelated functions be next to allancestorrelated functions indom.js.📖 ♻️
@choumx @jridgewell