Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Consolidate all Travis-related state in build-system/travis.js #20746

Merged
merged 5 commits into from Feb 12, 2019
Merged

🏗 Consolidate all Travis-related state in build-system/travis.js #20746

merged 5 commits into from Feb 12, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 8, 2019 •
edited

The build-system/ directory contains several references to various Travis environment variables.

This PR does the following:

  • Consolidates all references to process.env.TRAVIS* in one file, build-system/travis.js
  • Evaluates all current usage of Travis environment state, and uses the correct helper function (if incorrect)

This is a more comprehensive fix than the initial attempt in #20719

@rsimha rsimha self-assigned this Feb 8, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Feb 8, 2019

/to @danielrozenberg @estherkim

@rsimha rsimha mentioned this pull request Feb 8, 2019
Closed
danielrozenberg
danielrozenberg requested changes Feb 11, 2019
View reviewed changes
build-system/pr-check.js Show resolved Hide resolved
build-system/git.js Show resolved Hide resolved
build-system/git.js Show resolved Hide resolved
build-system/tasks/ava.js Outdated Show resolved Hide resolved
build-system/tasks/lint.js Outdated Show resolved Hide resolved
danielrozenberg
danielrozenberg approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May the odds be ever in our favour

@rsimha rsimha merged commit b843500 into ampproject:master Feb 12, 2019
@rsimha rsimha deleted the 2019-02-08-TravisUtils branch February 12, 2019 21:46
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@rsimha
🏗 Consolidate all Travis-related state in build-system/travis.js (a…
7a5f519 
…mpproject#20746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@estherkim estherkim Awaiting requested review from estherkim

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @danielrozenberg @googlebot