馃彈 Remove bundlesize
from package.json
#20776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
bundlesize
package to compute the size of the AMP runtime during PR checks. This is done here:amphtml/build-system/tasks/bundle-size.js
Lines 46 to 49 in ebe9247
It turns out that
bundlesize
uses theiltorb
library, which on Mac, requires Xcode to be installed on the device.Since calls to
npx foo
don't needfoo
to be listed inpackage.json
, we can removebundlesize
frompackage.json
. This should mitigate the requirement of Xcode on mac laptops and make initial setup easier.Fixes #19048
Closes #20775