Inabox: Change use of includes within whitelist checking to indexOf. #20805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taymonbeal
approved these changes
Feb 12, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…mpproject#20805) * Inabox: Change includes (which is not being polyfilled) to indexOf. * nit fix
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
…mpproject#20805) * Inabox: Change includes (which is not being polyfilled) to indexOf. * nit fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Array.prototype.includes is not being polyfilled within the host script. Not that it's beneficial to do so, but I initially assumed that this was the case and it wouldn't make a difference. But since it wasn't, as a result the host script would fail on old browsers (like on Android, where old Chrome versions are still rampant). This changes the use of includes() to the older indexOf() to ensure that it would work there.