✨Flick to dismiss docked video #20906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Tracks dragging velocity. * On drag end, video is dismissed if velocity is over a certain threshold by either: * sliding out, if the component area is out of view * or bouncing into position, if the component area is in view Videos docked to slot elements cannot be dragged, so this feature won't work in this case. An upcoming PR will introduce dragging for slot elements so they can be flicked-to-dismiss.
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Tracks dragging velocity. * On drag end, video is dismissed if velocity is over a certain threshold by either: * sliding out, if the component area is out of view * or bouncing into position, if the component area is in view Videos docked to slot elements cannot be dragged, so this feature won't work in this case. An upcoming PR will introduce dragging for slot elements so they can be flicked-to-dismiss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Videos docked to slot elements cannot be dragged, so this feature won't work in this case. An upcoming PR will introduce dragging for slot elements so they can be flicked-to-dismiss.