Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨auto-lightbox carousels under experiment #20910

Merged
merged 15 commits into from Feb 26, 2019
Merged

✨auto-lightbox carousels under experiment #20910

merged 15 commits into from Feb 26, 2019

Commits on Feb 18, 2019

  1. ✨auto-lightbox carousels under experiment

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    20faf6f View commit details
    Browse the repository at this point in the history

  2. Measure

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    fa481d2 View commit details
    Browse the repository at this point in the history

  3. Update test-amp-auto-lightbox

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    6752de8 View commit details
    Browse the repository at this point in the history

  4. Update test-carousel criteria for async, types

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    b30a981 View commit details
    Browse the repository at this point in the history

  5. Add remaining ADMISSIBLE_HTML_ELEMENTS

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    08e9314 View commit details
    Browse the repository at this point in the history

  6. remove element that's not possible due to validation

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    a9db67b View commit details
    Browse the repository at this point in the history

  7. Replace weird boilerplate

    @alanorozco
    alanorozco committed Feb 18, 2019
    Configuration menu
    Copy the full SHA
    1474b52 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2019

  1. Move tap check

    @alanorozco
    alanorozco committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    f0aa4a1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:ampproject/amphtml into lightbox-… 

    …carousel
    @alanorozco
    alanorozco committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    0bc467d View commit details
    Browse the repository at this point in the history

  3. Simplify

    @alanorozco
    alanorozco committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    83fddb1 View commit details
    Browse the repository at this point in the history

  4. oops

    @alanorozco
    alanorozco committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    0d6d084 View commit details
    Browse the repository at this point in the history

  5. why did the type checker not catch this

    @alanorozco
    alanorozco committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    721053a View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. types

    @alanorozco
    alanorozco committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    d3104e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. Merge branch 'master' into lightbox-carousel

    @alanorozco
    alanorozco committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    e40fa7b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:ampproject/amphtml into lightbox-… 

    …carousel
    @alanorozco
    alanorozco committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    c80ddd0 View commit details
    Browse the repository at this point in the history