✨Support <amp-delight-player dock> #20913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
Feb 18, 2019
| const placeholder = this.element.ownerDocument.createElement('div'); | ||
| const html = htmlFor(this.element); | ||
| const placeholder = | ||
| html`<div placeholder><amp-img layout=fill></amp-img></div>`; |
There was a problem hiding this comment.
@aghassemi Even though this makes it technically get the correct placeholder URL, the src pattern below appears to be broken :(
There was a problem hiding this comment.
@xymw has the Url for poster changed?
| @@ -1708,7 +1708,6 @@ export class VideoDocking { | |||
| this.getControls_().reset(); | |||
|
|
|||
| [ | |||
| element, | |||
There was a problem hiding this comment.
Caught this while manually testing. Same as #20912.
17 tasks
honeybadgerdontcare
approved these changes
Feb 19, 2019
extensions/amp-video-docking/0.1/test/validator-amp-video-docking-amp-delight-player.html
Outdated
Show resolved
Hide resolved
aghassemi
approved these changes
Feb 20, 2019
| const placeholder = this.element.ownerDocument.createElement('div'); | ||
| const html = htmlFor(this.element); | ||
| const placeholder = | ||
| html`<div placeholder><amp-img layout=fill></amp-img></div>`; |
There was a problem hiding this comment.
@xymw has the Url for poster changed?
Merged
honeybadgerdontcare
pushed a commit
that referenced
this pull request
Feb 20, 2019
- cl/234811475 Revision bump for #20913 - cl/234805704 Revision bump for #20911 - cl/234655757 allow render_only_if_payment_method_present for amp-payment-google-button - cl/234162273 Update comment regarding id/name attribute lists - cl/234053286 Update tagspecs using attribute `name` to include blacklist - cl/234038899 Update tagspecs using attribute `id` to include blacklist - cl/234023532 Revision bump for #20772
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
- cl/234811475 Revision bump for ampproject#20913 - cl/234805704 Revision bump for ampproject#20911 - cl/234655757 allow render_only_if_payment_method_present for amp-payment-google-button - cl/234162273 Update comment regarding id/name attribute lists - cl/234053286 Update tagspecs using attribute `name` to include blacklist - cl/234038899 Update tagspecs using attribute `id` to include blacklist - cl/234023532 Revision bump for ampproject#20772
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
- cl/234811475 Revision bump for ampproject#20913 - cl/234805704 Revision bump for ampproject#20911 - cl/234655757 allow render_only_if_payment_method_present for amp-payment-google-button - cl/234162273 Update comment regarding id/name attribute lists - cl/234053286 Update tagspecs using attribute `name` to include blacklist - cl/234038899 Update tagspecs using attribute `id` to include blacklist - cl/234023532 Revision bump for ampproject#20772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.