Update amp-subscriptions doc #20920
Merged
Update amp-subscriptions doc #20920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 15, 2019 11:15
subscriptions-entitlement-resolved only returns serviceId
subscriptions-service-registered data on wrong line
jpettitt
approved these changes
Feb 22, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Fix typo in amp-subscriptions doc * Change amp-subscriptions doc intro * amp-subscriptions doc: update amp-access section * amp-subscriptions doc: fix typo * amp-subscriptions doc: fix error in analytics event data subscriptions-entitlement-resolved only returns serviceId * amp-subscriptions doc: change section headings * amp-subscriptions doc: revise analytics section * amp-subscriptions doc: reorder analytics * amp-subscriptions doc: add subscriptions-link events * amp-subscriptions doc: fix analytics section typo subscriptions-service-registered data on wrong line
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Fix typo in amp-subscriptions doc * Change amp-subscriptions doc intro * amp-subscriptions doc: update amp-access section * amp-subscriptions doc: fix typo * amp-subscriptions doc: fix error in analytics event data subscriptions-entitlement-resolved only returns serviceId * amp-subscriptions doc: change section headings * amp-subscriptions doc: revise analytics section * amp-subscriptions doc: reorder analytics * amp-subscriptions doc: add subscriptions-link events * amp-subscriptions doc: fix analytics section typo subscriptions-service-registered data on wrong line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subscriptions-link analytics events.
Revise analytics section format.
Change analytics event order to better match the order the events are fired in a typical subscriptions lifecycle.
Change section capitalization.
Fix minor typos.