Validator rules/test for amp-action-macro #20928
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # | ||
| # Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS-IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the license. | ||
| # | ||
| tags: { # amp-action-macro | ||
| html_format: AMP | ||
| html_format: ACTIONS | ||
| tag_name: "SCRIPT" | ||
| extension_spec: { | ||
| name: "amp-action-macro" | ||
| version: "0.1" | ||
| version: "latest" | ||
| } | ||
| attr_lists: "common-extension-attrs" | ||
| } | ||
| tags: { # <amp-action-macro> | ||
| html_format: AMP | ||
| html_format: ACTIONS | ||
| tag_name: "AMP-ACTION-MACRO" | ||
| requires_extension: "amp-action-macro" | ||
| attrs: { | ||
| name: "arguments" | ||
| } | ||
| attrs: { | ||
| name: "execute" | ||
| mandatory: true | ||
| } | ||
| attr_lists: "mandatory-id-attr" | ||
| spec_url: "https://www.ampproject.org/docs/reference/components/amp-action-macro" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <!-- | ||
| Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS-IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the license. | ||
| --> | ||
| <!doctype html> | ||
| <html ⚡> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <link rel="canonical" href="./regular-html-version.html" /> | ||
| <meta name="viewport" content="width=device-width,minimum-scale=1"> | ||
| <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript> | ||
| <script async custom-element="amp-action-macro" src="https://cdn.ampproject.org/v0/amp-action-macro-0.1.js"></script> | ||
| <script async src="https://cdn.ampproject.org/v0.js"></script> | ||
| <style amp-custom> | ||
| .red { | ||
| color: red; | ||
| } | ||
| .green { | ||
| color: green; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
|
|
||
| <!-- Valid --> | ||
| <amp-action-macro id="action-macro-id" execute="amp-component.doSomething()"> | ||
|
There was a problem hiding this comment. We renamed this attribute to There was a problem hiding this comment. Yes, reason being that it clashed with the I don't think it's confusing. Now there is a 1 to 1 mapping between the caller that calls execute method and the action being invoked in the action macro, which is now associated with the execute attribute. Example: |
||
| </amp-action-macro> | ||
|
|
||
| <!-- Valid, optional arguments --> | ||
| <amp-action-macro id="action-macro-id" execute="amp-component.doSomething(foo=x,bar=y)" | ||
| arguments="x,y"> | ||
| </amp-action-macro> | ||
|
|
||
| <!-- Invalid, requires ID --> | ||
| <amp-action-macro execute="amp-component.doSomething()"> | ||
| </amp-action-macro> | ||
|
|
||
| <!-- Invalid, requires execute --> | ||
| <amp-action-macro id="action-macro-id"> | ||
| </amp-action-macro> | ||
|
|
||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| FAIL | ||
| | <!-- | ||
| | Copyright 2019 The AMP HTML Authors. All Rights Reserved. | ||
| | | ||
| | Licensed under the Apache License, Version 2.0 (the "License"); | ||
| | you may not use this file except in compliance with the License. | ||
| | You may obtain a copy of the License at | ||
| | | ||
| | http://www.apache.org/licenses/LICENSE-2.0 | ||
| | | ||
| | Unless required by applicable law or agreed to in writing, software | ||
| | distributed under the License is distributed on an "AS-IS" BASIS, | ||
| | WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| | See the License for the specific language governing permissions and | ||
| | limitations under the license. | ||
| | --> | ||
| | <!doctype html> | ||
| | <html ⚡> | ||
| | <head> | ||
| | <meta charset="utf-8"> | ||
| | <link rel="canonical" href="./regular-html-version.html" /> | ||
| | <meta name="viewport" content="width=device-width,minimum-scale=1"> | ||
| | <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript> | ||
| | <script async custom-element="amp-action-macro" src="https://cdn.ampproject.org/v0/amp-action-macro-0.1.js"></script> | ||
| | <script async src="https://cdn.ampproject.org/v0.js"></script> | ||
| | <style amp-custom> | ||
| | .red { | ||
| | color: red; | ||
| | } | ||
| | .green { | ||
| | color: green; | ||
| | } | ||
| | </style> | ||
| | </head> | ||
| | <body> | ||
| | | ||
| | <!-- Valid --> | ||
| | <amp-action-macro id="action-macro-id" execute="amp-component.doSomething()"> | ||
| | </amp-action-macro> | ||
| | | ||
| | <!-- Valid, optional arguments --> | ||
| | <amp-action-macro id="action-macro-id" execute="amp-component.doSomething(foo=x,bar=y)" | ||
| | arguments="x,y"> | ||
| | </amp-action-macro> | ||
| | | ||
| | <!-- Invalid, requires ID --> | ||
| | <amp-action-macro execute="amp-component.doSomething()"> | ||
| >> ^~~~~~~~~ | ||
| feature_tests/amp-action-macro.html:46:2 The mandatory attribute 'id' is missing in tag 'amp-action-macro'. (see https://www.ampproject.org/docs/reference/components/amp-action-macro) [AMP_TAG_PROBLEM] | ||
| | </amp-action-macro> | ||
| | | ||
| | <!-- Invalid, requires execute --> | ||
| | <amp-action-macro id="action-macro-id"> | ||
| >> ^~~~~~~~~ | ||
| feature_tests/amp-action-macro.html:50:2 The mandatory attribute 'execute' is missing in tag 'amp-action-macro'. (see https://www.ampproject.org/docs/reference/components/amp-action-macro) [AMP_TAG_PROBLEM] | ||
| | </amp-action-macro> | ||
| | | ||
| | </body> | ||
| | </html> | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have all these formats approved enabling this extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, good point though the extension augments and improves the dev experience with using actions so perhaps it's ok? But perhaps it's safer to exclude first and just add if it's requested.
@choumx thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start with AMP and ACTIONS conservatively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.