Only allowing amp-audio layout=nodisplay within amp-story.

[gmajoulet]

Forcing amp-audio within amp-story to use layout="nodisplay".

Using it with any other display breaks in different ways:

• The underlying <audio> element is created at a different time, potentially creating a race condition that results in the audio element not being handled by amp-story. It'd play when it's not supposed to, and not react to the story mute/unmute buttons.
• The audio element would be visible, but trying to interact with its controls would just navigate to the previous/next page instead of playing the audio.

[newmuis]

Adding in @aghassemi, who owns amp-audio

[Gregable]

Approved for validator changes, not for the decision itself.

[Gregable]

Actually, scratch that. This change potentially breaks existing pages. Do you have a reason to believe that this will not be the case?

[gmajoulet]

We've been talking offline about this, I should have added more context:

If any publisher is currently using that, the pages would be very broken already (cf PR description). The sound would be playing right away on page load on desktop, and as you navigate on mobile. And all that even if the story is muted :((. Also, the audio controls would not work, trying to interact with the audio element would trigger a page navigation instead of a audio play or other action.
Providing a fix today would require quite some work, both engineering to fix the race conditions and UX to make the audio controls interactive. We don't really have a use case for these today.

[aghassemi]

@gmajoulet I assume amp-story has its own UI control for audio and amp-audio is purely a sound source within amp-story?

[gmajoulet]

Correct :)
The audio plays for the visible page only, and users can mute/unmute it using this top right button

[Gregable]

We've been talking offline about this, I should have added more context:

If any publisher is currently using that, the pages would be very broken already (cf PR description). The sound would be playing right away on page load on desktop, and as you navigate on mobile. And all that even if the story is muted :((. Also, the audio controls would not work, trying to interact with the audio element would trigger a page navigation instead of a audio play or other action.
Providing a fix today would require quite some work, both engineering to fix the race conditions and UX to make the audio controls interactive. We don't really have a use case for these today.

Ack. I also confirmed that this wouldn't break anything in at least a small sample.

[gmajoulet]

Thanks everybody. :)