New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃彈 Use xenial
VMs on Travis for faster bootup
#20987
Conversation
I ran some tests, and the Xenial VM boot up time (~20 seconds) is half that of Trusty (~40 seconds). |
/to @estherkim @danielrozenberg This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick glance at https://travis-ci.org/ampproject/amphtml/pull_requests makes it look like this results in slower builds (~10 minutes in total) - I haven't done a complete evaluation though... not sure how to measure this over a longer period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I looked at the logs, the change in total running time appeared to arise from a high variance in the running time for git clone
. It's being tracked by #21175.
Meanwhile, I was able to measure a consistent reduction in boot time (not part of total job running time) from ~40s to ~20s. In addition, it's preferable to use a newer version of Linux instead of one that's several years old.
Good point though. We should keep track of total job running time and try to address the steps that are particularly slow. I believe the Sauce Labs
job is particularly notorious for being slow when tests start timing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool!! I added non-blocking comments.
One thing that could be blocking, though, is if the bundle size bot can't talk to the new VM (the check is pending right now). Not sure how to switch to Xenial and update BSB at the same time.
Also can you related this PR to this issue? #20887
Bundle-size bot is okay. I believe this problem stemmed from the fact that I un-pushed the last commit to this PR. I've re-run the job and will merge after it goes green. |
This PR switches the Travis VMs we use from Trusty to Xenial.
Advantages:
References:
Changes in this PR:
dist
in.travis.yml
fromtrusty
toxenial
pip
install of Python modules (in--user
mode, to work withoutsudo
)addons
sectionbundler
cache (it was used for Ruby gems, and is unnecessary)pip
caching (which doesn't work iflanguage
is notpython
), with directory-level caching of$HOME/.cache/pip
yarn
upgrade step since Xenial uses the latest version of yarn (1.13.0 as of today)Related to #20887