♻️ Extract CSS module #21007
Merged
♻️ Extract CSS module #21007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
css-module
branch
from
b129262
to
d12820d
Compare
dreamofabear
approved these changes
Feb 22, 2019
| @@ -18,6 +18,7 @@ import * as dom from '../../src/dom'; | |||
| import {BaseElement} from '../../src/base-element'; | |||
| import {createAmpElementForTesting} from '../../src/custom-element'; | |||
| import {loadPromise} from '../../src/event-helper'; | |||
| import {setScopeSelectorSupportedForTesting} from '../../src/css'; | |||
There was a problem hiding this comment.
Kinda weird, ideally should mock isScopeSelectorSupported instead.
Extracts CSS specific functions from `src/dom.js` into `src/css.js`.
jridgewell
force-pushed
the
css-module
branch
from
e7a2ff8
to
fca48d1
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Extract CSS module Extracts CSS specific functions from `src/dom.js` into `src/css.js`. * Fix build * Move assertIsName into css module * Move test
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Extract CSS module Extracts CSS specific functions from `src/dom.js` into `src/css.js`. * Fix build * Move assertIsName into css module * Move test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts CSS specific functions from
src/dom.jsintosrc/css.js.