Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension buffer to registerElement examples #21030

Merged
merged 2 commits into from Feb 25, 2019
Merged

Add extension buffer to registerElement examples #21030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e10a840
Add AMP.extension buffer to registerElement line.
caroqliu Feb 22, 2019
2535d74
Modify building-an-amp-extension.md to include extension buffer when …
caroqliu Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion build-system/tasks/extension-generator/index.js
View file
Open in desktop
Expand Up @@ -214,7 +214,9 @@ export class ${className} extends AMP.BaseElement {
}
}

AMP.registerElement('${name}', ${className});
AMP.extension('${name}', '0.1', AMP => {
AMP.registerElement('${name}', ${className});
});
`;
}

Expand Down
12 changes: 9 additions & 3 deletions contributing/building-an-amp-extension.md
View file
Open in desktop
Expand Up @@ -113,7 +113,9 @@ class AmpMyElement extends AMP.BaseElement {
}
}

AMP.registerElement('amp-my-element', AmpMyElement, CSS);
AMP.extension('amp-my-element', '0.1', AMP => {
AMP.registerElement('amp-my-element', AmpMyElement, CSS);
});
```

### BaseElement callbacks
Expand Down Expand Up @@ -287,7 +289,9 @@ AMP; all AMP extensions are prefixed with `amp-`. This is where you
tell AMP which class to use for this tag name and which CSS to load.

```javascript
AMP.registerElement('amp-carousel', CarouselSelector, CSS);
AMP.extension('amp-carousel', '0.1', AMP => {
AMP.registerElement('amp-carousel', CarouselSelector, CSS);
});
```

## Actions and events
Expand Down Expand Up @@ -697,7 +701,9 @@ Class AmpMyElement extends AMP.BaseElement {
}
}

AMP.registerElement('amp-my-element', AmpMyElement, CSS);
AMP.extension('amp-my-element', '0.1', AMP => {
AMP.registerElement('amp-my-element', AmpMyElement, CSS);
});
```

### Enabling and removing your experiment
Expand Down