📖 Fix experiment-related sample code in documentation #21031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te more similar to the original spirit of the example
gmajoulet
reviewed
Feb 22, 2019
gmajoulet
approved these changes
Feb 22, 2019
cvializ
suggested changes
Feb 22, 2019
There was a problem hiding this comment.
RE: the other PR, I think it should be userAssert, like in other live extensions with experiments enabled.
amphtml/extensions/amp-viz-vega/0.1/amp-viz-vega.js
Lines 74 to 76 in 81f0c14
I'm not sure why the generator and documentation say that a warn is sufficient.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Replace user.warn() with userAssert in accordance with gulp test checks * Replace userAssert() with correct usage of user().warn() to make update more similar to the original spirit of the example * Move comment to new line * manual lint * Replace user().warn() with userAssert
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* Replace user.warn() with userAssert in accordance with gulp test checks * Replace userAssert() with correct usage of user().warn() to make update more similar to the original spirit of the example * Move comment to new line * manual lint * Replace user().warn() with userAssert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building-an-amp-extension.mdprovides experiment-related code snippets that cause Travis checks to fail.this.getWin()withthis.winand incorrectuser.warn()withuserAssert()EXPERIMENTin calls toisExperimentOn()with its string literal equivalent (a required change due to check failures)