Visual diff comments and cleanup #21032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estherkim
approved these changes
Feb 22, 2019
test/visual-diff/visual-tests
Outdated
| @@ -127,21 +127,42 @@ | |||
| * // snapshot on Percy that demonstrate the flakiness of this test. | |||
| * "flaky": true | |||
| * }, | |||
| * | |||
| * Each webpages (or, optionally, each of its tests in the interactive_tests | |||
test/visual-diff/visual-tests
Outdated
| * performing these tasks in order: | ||
| * - Load the page and waits for network activity to stop (or up to 3 secs) | ||
| * - Wait for the built-in AMP loader dots to disappear from the page, meaning | ||
| * all AMP components finished being layed out and all resources, such as |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* visual-diff comments, explanation, and minor cleanup * Make the viewport resizing more clear * Double the number of parallel tabs * Fixed typos
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* visual-diff comments, explanation, and minor cleanup * Make the viewport resizing more clear * Double the number of parallel tabs * Fixed typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visual-diff/index.jsexplaining what happens inside that giant function that was extremely opaque until nowloading_[in]complete_css => loading_[in]complete_selectors(because they are css selectors, not css code)visual-testsfile