Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp-bind: Fix state/ready race condition #21033

Merged
merged 6 commits into from
Feb 25, 2019
Merged

amp-bind: Fix state/ready race condition #21033

merged 6 commits into from
Feb 25, 2019

Commits on Feb 22, 2019

  1. First pass on fixing race condition.

    William Chou committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    8e13ca1 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2019

  1. Fix amp-state tests.

    William Chou committed Feb 23, 2019
    Configuration menu
    Copy the full SHA
    d3d4c61 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2019

  1. Fix test-bind-impl.js.

    William Chou committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    6a7d157 View commit details
    Browse the repository at this point in the history

  2. Check for unbuilt <amp-state> instead of N setState() calls.

    William Chou committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    7ad14fe View commit details
    Browse the repository at this point in the history

  3. Tweak comments.

    William Chou committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    b1df7ac View commit details
    Browse the repository at this point in the history

  4. Add userAssert for 'src' attribute in refresh action.

    William Chou committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    dd94adc View commit details
    Browse the repository at this point in the history