✨Accept canonical URL in proxy form #21043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
Feb 26, 2019
torch2424
approved these changes
Feb 26, 2019
| @@ -36,6 +36,7 @@ module.exports = () => html`<div class="block"> | |||
| pattern="^(https?://)?[^\\s]+$" /> | |||
| </label> | |||
| <div class="form-info"> | |||
| <span>Takes canonical, AMPHTML and Google viewer URLs.</span> | |||
There was a problem hiding this comment.
Nice, thanks for adding the hint to the UI 😄 👍
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
The local proxy form now accepts three valid forms (with or without protocol): ## Canonical URL https://www.theverge.com/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters ## AMPHTML URL https://www.theverge.com/platform/amp/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters ## Google Viewer URL https://www.google.com/amp/s/www.theverge.com/platform/amp/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
The local proxy form now accepts three valid forms (with or without protocol): ## Canonical URL https://www.theverge.com/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters ## AMPHTML URL https://www.theverge.com/platform/amp/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters ## Google Viewer URL https://www.google.com/amp/s/www.theverge.com/platform/amp/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local proxy form now accepts three valid forms (with or without protocol):
Canonical URL
https://www.theverge.com/2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters
AMPHTML URL
https://www.theverge.com /platform/amp/ 2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters
Google Viewer URL
https://www.google.com/amp/s/www.theverge.com/platform/amp/ 2019/2/24/18236633/pizza-city-podcast-steve-dolinsky-chicago-new-york-pod-hunters