Fixed typo in fixed-elements-in-lightbox experiment
#21057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Feb 25, 2019
| this.discoverSelectors_(cssRules); | ||
| // Don't dereference cssRules we need to avoid "Can't access rules" | ||
| // DOMException due to reading a CORS stylesheet e.g. font. | ||
| this.discoverSelectors_(stylesheet.cssRules); |
There was a problem hiding this comment.
Should we add a try-catch?
There was a problem hiding this comment.
Searched error reporter for "cssRules" and only saw one report from amp-animation.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* i-amphtml-lightbox, not lightboxed. * Use consts and add test. * Revert img src. * Fix DOMException due to CORS stylesheet. * Fix comment.
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* i-amphtml-lightbox, not lightboxed. * Use consts and add test. * Revert img src. * Fix DOMException due to CORS stylesheet. * Fix comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20954. Fixes a typo and potential DOMException due to reading CORS stylesheet (e.g. fonts).
/to @jridgewell