🏗🚮 Clean up package.json by removing unused / adding missing deps
#21105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
requested review from
erwinmombay,
danielrozenberg,
cvializ and
estherkim
danielrozenberg
requested changes
Feb 26, 2019
danielrozenberg
approved these changes
Feb 26, 2019
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
npm-checkanddepcheckto generate a list of unused and missing dependencies inpackage.json. This PR adds / removes them as appropriate.Unfortunately, it's not easy to add an always-on check that runs
npm-checkanddepcheckfor all PRs because the tools report several false positives for dependencies that are in fact used in build / test tools (where there is norequireorimportstatement that mentions the dependency).